Enhancement/5039 remove x crypto fips #7072
Conversation
|
This pull request does not have a backport label. Could you fix it @kaanyalti? 🙏
|
go.mod
Outdated
| @@ -1,6 +1,6 @@ | |||
| module github.com/elastic/elastic-agent | |||
|
|
|||
| go 1.23.6 | |||
| go 1.24.0 | |||
There was a problem hiding this comment.
we can't bump to 1.24 yet :(
There was a problem hiding this comment.
Yes, I should set this PR as blocked because it does depend on 1.24
kaanyalti
force-pushed
the
enhancement/5039_remove_x_crypto_fips
branch
from
65d0fb3 to
8e74a0a
Compare
|
Blocked until go version can be bumped up to 1.24 |
kaanyalti
force-pushed
the
enhancement/5039_remove_x_crypto_fips
branch
from
df255d7 to
8d17eea
Compare
This reverts commit 6a2e5dd.
kaanyalti
force-pushed
the
enhancement/5039_remove_x_crypto_fips
branch
from
8d17eea to
ecea4ae
Compare
|
unblocked, go version bumped is merged |
| kind: enhancement | ||
|
|
||
| # Change summary; a 80ish characters long description of the change. | ||
| summary: Replaces x/crypto/pbkdf2 with the stdlib pbkdf2. Bumps go version to 1.24. Bumps beats version to commit cd883f511c3c |
There was a problem hiding this comment.
do we need a changelog ? This shouldn't be user-facing 🤔
There was a problem hiding this comment.
You're right, added it without thinking, removing it right away
| @@ -13,10 +13,10 @@ require ( | |||
| github.com/docker/docker v27.5.1+incompatible | |||
| github.com/docker/go-units v0.5.0 | |||
| github.com/dolmen-go/contextio v0.0.0-20200217195037-68fc5150bcd5 | |||
| github.com/elastic/beats/v7 v7.0.0-alpha2.0.20250218044933-ef79280d53a2 | |||
| github.com/elastic/beats/v7 v7.0.0-alpha2.0.20250305185131-1db044487726 | |||
There was a problem hiding this comment.
ah also, beats bump can't be backported (each branch targets a different branch). You might want to leave the bump out to make the PR easier to backport 🙂
There was a problem hiding this comment.
makes sense, I'll move the beats version bump to another PR
|
pierrehilbert
added
the
Team:Elastic-Agent-Control-Plane
|
Pinging @elastic/elastic-agent-control-plane (Team:Elastic-Agent-Control-Plane) |
| github.com/elastic/elastic-agent-autodiscover v0.9.0 | ||
| github.com/elastic/elastic-agent-client/v7 v7.17.1 | ||
| github.com/elastic/elastic-agent-libs v0.18.8 | ||
| github.com/elastic/elastic-agent-libs v0.18.9-0.20250305191329-ed5e3c2bdf69 |
There was a problem hiding this comment.
0.18.9 is out now, so we can use it here instead of a dev version.
What does this PR do?
Removes x/crypto usage
Why is it important?
We need to move away from using x/crypto for fips compliance
Checklist
[ ] I have commented my code, particularly in hard-to-understand areas[ ] I have made corresponding changes to the documentation[ ] I have made corresponding change to the default configuration files[ ] I have added tests that prove my fix is effective or that my feature works./changelog/fragmentsusing the changelog tool[ ] I have added an integration test or an E2E testDisruptive User Impact
None
How to test this PR locally
Ci tests should be enough
Related issues